Skip to content

Allow scan in AP mode #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MartinHruza
Copy link
Contributor

Description

This PR adds support for wifi scan in AP mode by using APSTA instead of pure AP mode.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • [ x ] Git history is clean — commits are squashed to the minimum necessary.

@MartinHruza MartinHruza changed the title Allow scan in ap mode Allow scan in AP mode Jan 9, 2025
@mantriyogesh
Copy link
Collaborator

@kapilkedawat , PTAL..

@mantriyogesh
Copy link
Collaborator

@MartinHruza ,

We sincerely appreciate for your time and efforts in solving this problem.
We will review and get back to you on this.

@MartinHruza
Copy link
Contributor Author

@mantriyogesh you're welcome. Please let me know if anything needs any adjustment. I'll help as much as I can to push it to the master branch.

@MartinHruza MartinHruza force-pushed the allow-scan-in-ap-mode branch from bb9d320 to 7121dba Compare January 10, 2025 11:44
@MartinHruza MartinHruza force-pushed the allow-scan-in-ap-mode branch from 7121dba to a35acd4 Compare January 10, 2025 12:01
@MartinHruza MartinHruza force-pushed the allow-scan-in-ap-mode branch from a35acd4 to 0096b6b Compare January 10, 2025 14:47
@Donach
Copy link

Donach commented Feb 4, 2025

Any update on this @mantriyogesh ?
👍 for merging this asap.

@kapilkedawat
Copy link
Contributor

@Shreyas0-7 PTAL

@Shreyas0-7
Copy link
Contributor

Hey @MartinHruza thanks for your contribution we are reviewing the PR and doing internal checks

@mayurpatel19912009
Copy link

Great. We are waiting for this feature as well.
Just to understand, a query:
Will we be able to scan only and NOT connect to other AP(if i get it correct) while own Hotspot is on?

@MartinHruza
Copy link
Contributor Author

@mayurpatel19912009 Yes, if you are in AP mode, you can only scan but not connect to other APs.

Since it's 3 months since out last communication here, do you have any update @Shreyas0-7 / @mantriyogesh ?

@mantriyogesh
Copy link
Collaborator

Hello @MartinHruza i am extremely sorry. Our team would get this pulled this week.

espressif-bot pushed a commit that referenced this pull request May 18, 2025
@Shreyas0-7
Copy link
Contributor

@MartinHruza, thank you for your contribution.

@mantriyogesh
Copy link
Collaborator

@MartinHruza,

Our sincere apologies once again for the delay in merging your contribution. We took a bit of additional time to test a few corner cases that we initially overlooked during the review, and these came up just before the final merge.

We truly appreciate your efforts and, most of all, your patience throughout this process. Thank you very much!

Below are your commits pushed on master. If everything looks good to you, we can please proceed to close this issue.
Screenshot 2025-05-19 at 2 34 04 PM

@mayurpatel19912009
Copy link

mayurpatel19912009 commented May 20, 2025

@espressif team

I tested it during AP on. it worked. Thank you so much for merging this.

@mantriyogesh
Copy link
Collaborator

As the commits submitted in this PR are already merged on master, we are closing this PR, @MartinHruza .

If in case you have further inputs or anything to discuss, please feel free to re-open..

@mantriyogesh
Copy link
Collaborator

Thanks @mayurpatel19912009 , for confirming ! 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants